Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example: add autocomplete #674

Merged
merged 2 commits into from
Mar 13, 2023
Merged

Example: add autocomplete #674

merged 2 commits into from
Mar 13, 2023

Conversation

jpnurmi
Copy link
Member

@jpnurmi jpnurmi commented Mar 13, 2023

NOTE: The banner page is the default because the autocomplete page is not the most attractive page... :P

image

Screenshot from 2023-03-13 11-26-41

@jpnurmi
Example: add autocomplete
6805ab6 
Keep banner as default because the autocomplete page is not the most
attractive page... :P
@jpnurmi
Remove unnecessary optionsWidth - it's now automatic
f82cbd9
@jpnurmi
Copy link
Member Author

jpnurmi commented Mar 13, 2023 •
edited
Loading

Imo the banner page is the best candidate for a default page

Agreed! It looks nice

We can set the default index with a YaruPageController.

@Jupi007 I set initialIndex: 1 as a quick solution because we have a different set of pages in MD and navi-rail modes so one cannot share the controller due to different length... oops

@Jupi007
Copy link
Member

Jupi007 commented Mar 13, 2023 •
edited
Loading

@Jupi007 I set initialIndex: 1 as a quick solution because we have a different set of pages in MD and navi-rail modes so one cannot share the controller due to different length... oops

Indeed, I am also experiencing this problem :D
The initialIndex seems fine to me 👍

Jupi007
Jupi007 approved these changes Mar 13, 2023
View reviewed changes
Copy link
Member

@Jupi007 Jupi007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks :)

@jpnurmi jpnurmi merged commit f02c4c7 into ubuntu:main Mar 13, 2023
@jpnurmi jpnurmi deleted the autocomplete-example branch March 13, 2023 10:44
@jpnurmi jpnurmi mentioned this pull request Mar 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jupi007 Jupi007 Jupi007 approved these changes

@Feichtmeier Feichtmeier Awaiting requested review from Feichtmeier

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jpnurmi @Jupi007