feat: add YaruScrollViewUndershoot
#789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feichtmeier
approved these changes
Oct 20, 2023
There was a problem hiding this comment.
nice! very nice idea, cant see any mistake in the code
if you want let @d-loose double check for code
|
@d-loose Can you quickly check this PR, please? |
|
Thanks @d-loose |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new
YaruScrollViewUndershootwidget which displays an undershoot at the start and/or end of a scroll view, when the scroll offset is not at the very beginning or end. It works in both scroll axis, and you can also disable the start or end undershoot (ex: if the scroll view is close to the window border it is useless to add an undershoot).It is also providing a
buildernamed constructor which handle theScrollControllercreation and lifecycle, so we don't need to create a statefull widget to use this.Capture.video.du.2023-10-20.18-11-11.webm
I tried to mimic Libadwaita look: