Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Otter Generate should deduplicate user-specified requirements with otter-provided ones #794

Open
chrispyles opened this issue Apr 4, 2024 · 0 comments
Open

Otter Generate should deduplicate user-specified requirements with otter-provided ones #794

chrispyles opened this issue Apr 4, 2024 · 0 comments
Labels
enhancement New feature or request
Projects
Otter-Grader Issues and Tasks
Milestone
v6.0.0

Comments

@chrispyles
Copy link
Member

chrispyles commented Apr 4, 2024 •
edited
Loading

Currently, otter generate just appends the user-specified requirements to its own list:

otter-grader/otter/generate/__init__.py

Line 96 in dc50e33

*self.requirements,

Instead, it should dedupe these requirements, overriding otter's default with the user's (to keep user-specified version info).

Example: User's specified requirements

pandas==2.0.0
otter-grader

This will cause an image build failure currently.
@chrispyles chrispyles added the enhancement New feature or request label Apr 4, 2024
@chrispyles chrispyles added this to the v6.0.0 milestone Apr 4, 2024
@chrispyles chrispyles added this to Icebox in Otter-Grader Issues and Tasks via automation Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Otter-Grader Issues and Tasks
Icebox
Milestone
v6.0.0
Development

No branches or pull requests
1 participant
@chrispyles