Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hylar as a dependency of a strict-Node.js 13 application #13

Closed
StatelessCat opened this issue Dec 11, 2019 · 1 comment
Closed

Hylar as a dependency of a strict-Node.js 13 application #13

StatelessCat opened this issue Dec 11, 2019 · 1 comment

Comments

@StatelessCat
Copy link

Hi,
When adding Hylar@1.8.5 as a dependency for a project that requires Node.js 13 to run, I did not succeed in building its dependencies, using npm nor yarn.

The faulty "sqlite3" transitive dependency of your project (multer@1.4.2 -> rdflib@0.17.1 -> rdfstore@0.9.17 -> sqlite3@3.1.13) prevent it.

The workaround is obviously to install Hylar as Node.js 10, then to require it in Node.js 13, which works, but not optimal. Or just to expressly --ignore-engines and runtimes checks in npm but it did not work for me (still a problem to build sqlite3).

What is your opinion on it?
Is it possible to change multer as an optional dependency?
What I'm missing on this problem?

Thanks.

@mterdjimi
Copy link
Member

mterdjimi commented Jan 7, 2020

Hello and thanks for raising this issue.
Since rdfstore is not maintained, I forked it to remove its vulnerabilities. This includes an upgrade of sqlite3 to its latest version. HyLAR 1.10 now uses this forked rdfstore package, which potentially solves problems with Node 13.

Let me know if this new version works on your side. If multer still causes dysfunctions, it should be solved in the next HyLAR release.

MT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants