Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor lock_sitefarm_features custom module into a contrib module #176

Open
rickvug opened this issue Oct 26, 2017 · 2 comments
Open

Refactor lock_sitefarm_features custom module into a contrib module #176

rickvug opened this issue Oct 26, 2017 · 2 comments

Comments

@rickvug
Copy link

rickvug commented Oct 26, 2017

Rick from Acquia here. I was talking to Shawn at BADCamp about how SiteFarm was managing features. He mentioned that SiteFarm is able to selectively "lock" certain base distribution configuration while allowing the rest of the configuration to be altered on a per site basis. This sounds like an excellent approach to many site governance so I searched for the Contrib module and couldn't find it. I now realize that this capability comes from the custom module lock_sitefarm_features. This sounds like the perfect candidate to rename (and maybe slightly refactor?) as a contributed module. Consider this issue a request!

@dearmond
Copy link
Member

Thanks, Rick, you're probably right. In fact, it might simply be a good addition to the Features module itself, rather than a separate module.

@mrkmiller
Copy link
Contributor

I'll look into this. Concerning the features module, this doesn't actually have anything to do with the Features module. It was named that way simply because we were packaging code with Features and we wanted to lock parts of them down. The module locks items based off of their machine name prefix. In our case it was sf_. However that can be edited or added to in the config. Additional non-prefixed machine names can also be flagged individually.

The one thing that might be a little tough in making this a contrib module is that we were locking stuff down for our specific use case. There isn't a mechanism yet for locking down paths/ui/config to areas that we haven't explicitly declared. Currently it only locks down the following areas:

  • node types
  • block content types
  • filter formats
  • pathauto patterns
  • taxonomy vocabularies
  • views
  • image styles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants