Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to enable responsive video embeds #52

Closed
cjg89 opened this issue Mar 22, 2019 · 1 comment
Closed

Add option to enable responsive video embeds #52

cjg89 opened this issue Mar 22, 2019 · 1 comment
Assignees

Comments

@cjg89
Copy link
Member

cjg89 commented Mar 22, 2019

See UCF/Today-Child-Theme#19 as an example. A snippet like this would help ensure that video embeds (YouTube, Vimeo, etc) are always responsive when included in page/post content.

However, since some sites may already be accommodating for this by adding wrapper markup manually, we'll need to either:

a) add an option, disabled by default, that activates the responsive embed wrapper markup, or

b) adds some additional logic to the_content (or elsewhere?) that detects duplicate <div class="embed-responsive ..."> wrappers and consolidates them.

@cjg89
Copy link
Member Author

cjg89 commented Jun 5, 2019

Added option to enable responsive oEmbed and video content in v0.4.0.

@cjg89 cjg89 closed this as completed Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants