Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UDOIT Does Not Remove Suggestion/Error After Editing the Webcourse Page #896

Closed
lastingParadox opened this issue Mar 14, 2023 · 1 comment · Fixed by #903
Closed

UDOIT Does Not Remove Suggestion/Error After Editing the Webcourse Page #896

lastingParadox opened this issue Mar 14, 2023 · 1 comment · Fixed by #903

Comments

@lastingParadox
Copy link

lastingParadox commented Mar 14, 2023

While completing tickets, I ran into an issue regarding errors/suggestions that cannot be edited on UDOIT. Whenever I edited a page's content, for instance, changing a styled paragraph to a header or removing white highlight behind a text element, UDOIT would not recognize the page being altered upon reloading the LTI. This means that the error/suggestion would not be removed, and in the error/suggestion, the problematic HTML snippet before my change to it would still show up.

While I can occasionally get UDOIT to recognize the fix upon re-saving the page, sometimes UDOIT will just outright not recognize that the page was changed, making the error seem bugged. Trying to manually resolve the error will just give a red error alert.

Screenshot 2023-03-14 at 12 43 01 PM

Below is are images that show the warning still persisting after having changed the "Action Item" text from a paragraph to an h2 header.

Screenshot 2023-03-14 at 11 17 35 AM

Screenshot 2023-03-14 at 11 18 20 AM

Running Firefox if that makes a difference.

@taheralfayad
Copy link
Contributor

taheralfayad commented Apr 13, 2023

Issue Description:

After further investigation of this issue, I think I've found where the conflicts might be happening. If a user were to change the html of an issue prior to marking it as resolved, then UDOIT will not be able to find that HTML upon reloading the state, hence the "Fixed HTML was not replaced in LMS" error. Important to note however, is that every time I fixed an error manually and marked it as resolved, that error was not found after a refresh of the UDOIT LTI (but it was also not found in the resolved issues filter as well. I think the two fixes to this issue would be:

1.) Find a less generic and a less intimidating error message than "Fixed HTML was not found in LMS. Please contact administrator" so as to let the user know that their changes will actually be reflected in both UDOIT and the LMS.

2.) Find a way to retain the previous state of the issue in order to show it in the resolved issues section.

Images:

Before manually fixing the issue:
Screenshot 2023-04-13 at 3 07 12 PM

The issue after the user checks "mark as resolved" after the html content has been altered:
Screenshot 2023-04-13 at 3 08 22 PM

Searching with the "resolved issues" filter (as you can see, the issue in question does not show up in as a manually resolved issue):
Screenshot 2023-04-13 at 3 08 46 PM

Number of issues after the user manually fixes the issue:
Screenshot 2023-04-13 at 3 10 32 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants