Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slight adjustment to CONVERT module signature #6

Closed
bufordrat opened this issue Oct 28, 2021 · 0 comments · Fixed by #5
Closed

Slight adjustment to CONVERT module signature #6

bufordrat opened this issue Oct 28, 2021 · 0 comments · Fixed by #5
Assignees

Comments

@bufordrat
Copy link
Contributor

bufordrat commented Oct 28, 2021

Change acopy and amap in CONVERT module signature

Update CONVERT so that amap and acopy take two inputs: one for modifying the content-type mime header and one for modifying the data of an attachment. Since strings in OCaml are just sequences of bytes, the inputs to each of these functions should be functions of type string -> string.

New signature (for now, until we change it):

module type CONVERT =
  sig
    type filepath
    type parsetree
    type htransform = string -> string
    type dtransform = string -> string
    val parse : string -> parsetree
    val amap : htransform -> dtransform -> parsetree -> parsetree
    val acopy : htransform -> dtransform -> parsetree -> parsetree
    val to_string : parsetree -> string
    val convert : filepath -> string -> string
    val acopy_email : string -> (string -> string) -> string
  end
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant