Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proper configurations for flake8 and mypy #82

Closed
astanziola opened this issue Aug 12, 2022 · 1 comment
Closed

Add proper configurations for flake8 and mypy #82

astanziola opened this issue Aug 12, 2022 · 1 comment
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@astanziola
Copy link
Member

It is tricky to configure mypy and flake8 for this project, for several reason

  • Operator overloading means that mypy sees a redefinition of unused functions. This is a problems inherited from plum.
  • Use black and flake8? I like the 2 spaces indent, but doesn't conform with PEP, so perhaps it is time to let it go..
@astanziola astanziola added bug Something isn't working help wanted Extra attention is needed labels Aug 12, 2022
@astanziola
Copy link
Member Author

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@astanziola