Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some distributions only fit positive data #4

Open
helen-zhu opened this issue Jan 29, 2024 · 2 comments
Open

Some distributions only fit positive data #4

helen-zhu opened this issue Jan 29, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@helen-zhu
Copy link
Collaborator

In fit.and.evaluate, we include options for weibull, gamma, exp and lnorm which are distributions that only have data density for positive values. This is counter-intuitive given that we generate our distribution of aggregated z-scores by summing up negative z-scores.

@helen-zhu helen-zhu added the bug Something isn't working label Jan 29, 2024
@helen-zhu
Copy link
Collaborator Author

I think it should be noted that in the functions cosine.similarity.cutoff and cosine.similarity.iterative, the signs of the data are flipped before fitting distributions. We should probably add a parameter to fit.and.evaluate to match to avoid confusion.

@helen-zhu
Copy link
Collaborator Author

I think it might actually just be the zeros that are throwing this error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant