Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If possible, add headings to this embed https://uclalibrary.github.io/research-tips/assets/animation/abstract-animation #152

Closed
woof84 opened this issue Jul 17, 2020 · 1 comment
Closed

If possible, add headings to this embed https://uclalibrary.github.io/research-tips/assets/animation/abstract-animation #152

woof84 opened this issue Jul 17, 2020 · 1 comment

Comments

@woof84
Copy link
Collaborator

woof84 commented Jul 17, 2020

No description provided.

@woof84
Copy link
Collaborator Author

woof84 commented Oct 9, 2020

Added an h1 to the title of the embed, and fixed an error about adding a document language. Now there are 0 errors and 2 alerts.

Also I'm pretty certain this wouldn't be able to be used by screen reader. The words in the html file are totally out of order. I wonder what to do about this?

Closing for now because I fixed the issue!

@woof84 woof84 closed this as completed Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@woof84