Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visibility default to public on batch work creation form #1202

Merged
merged 1 commit into from Mar 7, 2017

Conversation

crowesn
Copy link
Contributor

@crowesn crowesn commented Mar 6, 2017

Fixes #1121
Fixes #1204

Make default visibility public on batch work creation form.

Changes proposed in this pull request:

  • Sufia override - app/controllers/concerns/sufia/batch_uploads_controller_behavior.rb

@crowesn crowesn force-pushed the feature/#1121-batch-creation-default-visibility branch 3 times, most recently from 189335e to cfbee76 Compare March 6, 2017 16:57
@crowesn
Copy link
Contributor Author

crowesn commented Mar 6, 2017

Adding batch_uploads_controller_behavior.rb has exposed more to coveralls, resulting in reduced coverage.

@scherztc scherztc self-assigned this Mar 6, 2017
@crowesn crowesn force-pushed the feature/#1121-batch-creation-default-visibility branch 3 times, most recently from bf33ccc to 154ee6c Compare March 6, 2017 19:26
@crowesn crowesn force-pushed the feature/#1121-batch-creation-default-visibility branch from 154ee6c to 49f6ba5 Compare March 6, 2017 19:32
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.8%) to 97.983% when pulling 49f6ba5 on feature/#1121-batch-creation-default-visibility into 66117aa on develop.

@crowesn crowesn changed the title [WIP] Visibility default to public on batch work creation form Visibility default to public on batch work creation form Mar 6, 2017
@scherztc
Copy link
Contributor

scherztc commented Mar 6, 2017

@crowesn : It looks like you found something to use for resource_type? Did you decide to keep it in there?

screen shot 2017-03-06 at 4 30 59 pm

@crowesn
Copy link
Contributor Author

crowesn commented Mar 7, 2017 via email

@scherztc scherztc merged commit ac72563 into develop Mar 7, 2017
@scherztc scherztc deleted the feature/#1121-batch-creation-default-visibility branch March 7, 2017 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants