missing break after case statement in opj_dwt_decode_real

[gcode-importer]

Originally reported on Google Code with ID 274

            switch(j) {
            case 3: aj[k+w*2] = h.wavelet[k].f[2];
            case 2: aj[k+w  ] = h.wavelet[k].f[1];
            case 1: aj[k    ] = h.wavelet[k].f[0];
            }

Reported by boxerab on 2014-03-05 03:25:56

[gcode-importer]

I do not see why ?

Reported by malaterre on 2014-03-07 10:09:13

• Labels added: Priority-Low
• Labels removed: Priority-Medium

[gcode-importer]

It forces the code to check all three case statements without a break.
Also, looks like perhaps it was forgotten. 
Best practice is to add a break.

Reported by boxerab on 2014-03-07 13:14:27

[gcode-importer]

Please either:
- provide a test case to understand what is wrong with this *valid* code
- or point to the section in part1 you think is incorrect.

From here, it looks as if you are reporting some kind of warning from your compiler.

Marking as wontfix for now.

Reported by malaterre on 2014-03-07 14:29:23

• Status changed: WontFix
• Labels added: Milestone-Release2.1

[gcode-importer]

Hi Mathieu,
IMHO, the less warnings the better. After more than, say 20 compiler warnings,
one tends to not look too carefully at them, and one might miss an actual bug.
Aaron

Reported by boxerab on 2014-03-07 15:52:11

[gcode-importer]

All 20 OS (Win/Lin/Mac) & Compilers (clang, gcc, VS) configurations are here: http://my.cdash.org/index.php?project=OPENJPEG

Where do you see this warning ?

Reported by malaterre on 2014-03-07 16:02:18

[gcode-importer]

I am using Eclipse CDT Codan:

https://wiki.eclipse.org/CDT/designs/StaticAnalysis

Reported by boxerab on 2014-03-07 16:36:44

[gcode-importer]

Codan gives me about 22 warnings

Reported by boxerab on 2014-03-07 16:42:42