Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce memory significantly for single tile RGB encoding #375

Closed
gcode-importer opened this issue Jul 14, 2014 · 10 comments
Closed

reduce memory significantly for single tile RGB encoding #375

gcode-importer opened this issue Jul 14, 2014 · 10 comments
Assignees

Comments

@gcode-importer
Copy link

Originally reported on Google Code with ID 375

For t1 encoder, use tile data as input rather than creating a new buffer for each code
block and copying into that buffer

For single tile encoding, simply re-use image component data as input, rather than
allocating two copies of each component and copying into the tile component.

Please see attached patch file.


Reported by boxerab on 2014-07-14 13:18:47


- _Attachment: [0001-for-t1-encoder-use-tile-data-rather-than-creating-a-.patch](https://storage.googleapis.com/google-code-attachments/openjpeg/issue-375/comment-0/0001-for-t1-encoder-use-tile-data-rather-than-creating-a-.patch)_
@gcode-importer
Copy link
Author

Reported by detonin on 2014-07-17 07:29:54

  • Status changed: Accepted
  • Labels added: Priority-High
  • Labels removed: Priority-Medium

@gcode-importer
Copy link
Author

Here's the patch for r2903

Not yet tested against the whole test suite.
On data/input/nonregression/Cevennes1.bmp, memory allocations are lowered by about
30% :
Total allocations reported by Instrument tool on MacOS : 248,83MB before & 176,72MB
after
Maximum Heap usage reported by valgrind massif : 233,10MB before & 161,00MB after

Reported by mayeut on 2014-10-17 21:56:25

@gcode-importer
Copy link
Author

Previous patch buggy against the whole test suite (opj_j2k_write_tile).
This one corrects this.

Reported by mayeut on 2014-10-18 17:19:29

@gcode-importer
Copy link
Author

Thanks for testing my baby !

Reported by boxerab on 2014-10-18 20:14:50

@gcode-importer
Copy link
Author

Reported by detonin on 2014-10-22 12:47:41

  • Labels added: Type-Enhancement
  • Labels removed: Type-Defect

@gcode-importer
Copy link
Author

Reported by detonin on 2014-10-22 23:05:30

  • Status changed: Verified

@gcode-importer
Copy link
Author

Attach patch against r2918
Still no regressions with Test Suite

Reported by mayeut on 2014-10-23 17:55:34


- _Attachment: [issue375-r2918.patch](https://storage.googleapis.com/google-code-attachments/openjpeg/issue-375/comment-7/issue375-r2918.patch)_

@gcode-importer
Copy link
Author

Attach patch against r2922

Reported by mayeut on 2014-10-30 22:51:19


- _Attachment: [issue375-r2922.patch](https://storage.googleapis.com/google-code-attachments/openjpeg/issue-375/comment-8/issue375-r2922.patch)_

@gcode-importer
Copy link
Author

This issue was closed by revision r2924.

Reported by detonin on 2014-11-03 14:51:52

  • Status changed: Fixed

@gcode-importer
Copy link
Author

Yay!!!!

Reported by boxerab on 2014-11-06 19:58:30

@gcode-importer gcode-importer self-assigned this Jun 11, 2015
@rouault rouault added this to Suggested in OPJ_OPTIM_ROUND1 Jun 14, 2017
@rouault rouault moved this from Suggested to DOING in OPJ_OPTIM_ROUND1 Jul 5, 2017
@rouault rouault removed this from DOING in OPJ_OPTIM_ROUND1 Jul 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant