Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5pm c avg class size by dept #76

Merged
merged 36 commits into from Dec 10, 2020
Merged

5pm c avg class size by dept #76

merged 36 commits into from Dec 10, 2020

Conversation

paritoshjha24
Copy link
Contributor

@paritoshjha24 paritoshjha24 commented Dec 9, 2020

This PR implements the "Average Class Size by Department" statistics page, where a user can select a start and end quarter and view the average class size for all departments (including Undergraduate and Graduate courses) over that range of time. Closes #46

Before:

course-search-pr-76-before

After:

course-search-pr-76-after

jvoucsb and others added 30 commits December 8, 2020 22:38
@codecov
Copy link

codecov bot commented Dec 9, 2020

Codecov Report

Merging #76 (9fce7d4) into main (2dbd09a) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##                main       #76   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       288       302   +14     
===========================================
  Files             54        61    +7     
  Lines            850       943   +93     
  Branches          20        21    +1     
===========================================
+ Hits             850       943   +93     
Impacted Files Coverage Δ Complexity Δ
javascript/src/main/App.js 100.00% <ø> (ø) 0.00 <0.00> (ø)
javascript/src/main/components/Nav/AppNavbar.js 100.00% <ø> (ø) 0.00 <0.00> (ø)
...pt/src/main/components/Statistics/ClassSizeForm.js 100.00% <100.00%> (ø) 0.00 <0.00> (?)
...t/src/main/components/Statistics/ClassSizeTable.js 100.00% <100.00%> (ø) 0.00 <0.00> (?)
...main/components/Statistics/DepartmentFormSelect.js 100.00% <100.00%> (ø) 0.00 <0.00> (?)
...rc/main/components/Statistics/QuarterFormSelect.js 100.00% <100.00%> (ø) 0.00 <0.00> (?)
javascript/src/main/pages/Statistics/ClassSize.js 100.00% <100.00%> (ø) 0.00 <0.00> (?)
javascript/src/main/services/statisticsService.js 100.00% <100.00%> (ø) 0.00 <0.00> (?)
...ucsb/courses/controllers/StatisticsController.java 100.00% <100.00%> (ø) 3.00 <1.00> (+1.00)
...csb/courses/documents/statistics/AvgClassSize.java 100.00% <100.00%> (ø) 13.00 <13.00> (?)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dbd09a...9fce7d4. Read the comment docs.

Copy link
Contributor

@jvoucsb jvoucsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deployed locally and found no bugs.

There is one change needed and one to consider. Other than that, looks good to me.

javascript/src/main/components/Nav/AppNavbar.js Outdated Show resolved Hide resolved
src/main/resources/application.properties Show resolved Hide resolved
Copy link
Contributor

@hdinh77 hdinh77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

besides the changes about PORT that justin mentioned (this is more for a local user that needs to use a different port), looks good!

Copy link
Contributor

@jvoucsb jvoucsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick fix. But otherwise, looks good to me.

javascript/src/main/App.js Show resolved Hide resolved
@jvoucsb jvoucsb self-requested a review December 10, 2020 06:13
@pconrad pconrad temporarily deployed to ucsb-courses-search-f20-qa December 10, 2020 17:57 Inactive
Copy link
Contributor

@phtcon phtcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 40 points

@phtcon phtcon merged commit 1852208 into main Dec 10, 2020
@phtcon phtcon added 40 40 points and removed READY for STAFF REVIEW labels Dec 10, 2020
@andrewhlu andrewhlu deleted the 5pm-c-AvgClassSizeByDept branch January 27, 2021 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Average class size by department
6 participants