New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5pm c avg class size by dept #76
Conversation
Codecov Report
@@ Coverage Diff @@
## main #76 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 288 302 +14
===========================================
Files 54 61 +7
Lines 850 943 +93
Branches 20 21 +1
===========================================
+ Hits 850 943 +93
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deployed locally and found no bugs.
There is one change needed and one to consider. Other than that, looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
besides the changes about PORT that justin mentioned (this is more for a local user that needs to use a different port), looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick fix. But otherwise, looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 40 points
This PR implements the "Average Class Size by Department" statistics page, where a user can select a start and end quarter and view the average class size for all departments (including Undergraduate and Graduate courses) over that range of time. Closes #46
Before:
After: