Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 馃悰 Set anchor link scroll position below fixed site header height #262

Merged
merged 1 commit into from Aug 25, 2023
Merged

fix: 馃悰 Set anchor link scroll position below fixed site header height #262

merged 1 commit into from Aug 25, 2023

Conversation

knice
Copy link
Member

@knice knice commented Aug 24, 2023

What does this do/fix?

  • Set anchor link scroll position below fixed site header height.
  • Adds a momentary background-color to indicate the anchor target

@knice
fix: 馃悰 Set anchor link scroll position below fixed site header height
d8327e6 
Also adds a momentary background-color to indicate the anchor target
@knice knice requested a review from Herm71 August 24, 2023 21:48
@knice knice added the bug Something isn't working label Aug 24, 2023
Herm71
Herm71 approved these changes Aug 25, 2023
View reviewed changes
Copy link
Member

@Herm71 Herm71 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix. Works!

@knice knice merged commit f0f2272 into main Aug 25, 2023
@knice knice deleted the fix-anchor-links branch January 24, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Herm71 Herm71 Herm71 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@knice @Herm71