Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wind attacks #25

Merged
merged 7 commits into from May 3, 2023
Merged

Wind attacks #25

merged 7 commits into from May 3, 2023

Conversation

alanlwang1
Copy link
Contributor

Added logic for wind attacks, cooldowns, and ammo
Added code for displaying cooldowns/ammo on client
Refactored code for respawning to only use spawn command
Changed cooldown system to store cooldown value instead of timestamp because converting on client side was too hard

Copy link
Contributor

@xiyan128 xiyan128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -65,7 +64,8 @@ impl InputEventProcessor {
VirtualKeyCode::Space => Some((GameKeyKind::Pressable, Jump)),
VirtualKeyCode::LShift => Some((GameKeyKind::Pressable, Spawn)),
// match PressRelease keys
VirtualKeyCode::F => Some((GameKeyKind::PressRelease, Action(Attack))),
VirtualKeyCode::LShift => Some((GameKeyKind::PressRelease, Spawn)),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are these PressRelease?

@YunxiangChi YunxiangChi merged commit e5d8f6a into main May 3, 2023
6 checks passed
@xiyan128 xiyan128 deleted the wind_attacks branch May 3, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants