-
Notifications
You must be signed in to change notification settings - Fork 5
Remove download function for UCSD-only video objects #461
Comments
@gamontoya do you have any idea when this might moved out of the icebox and into a sprint? The CARS licensed Chinese videos cannot be ingested and made available until the download issue is resolved. |
@GregReser - Do you know if there is any UCSD-only video objects in qa? I'm done removing the download function for video object. I would like to deploy the change to qa for testing first. Thanks |
@VivianChu All these videos in this collection: http://libraryqa.ucsd.edu/dc/collection/bb19126574 |
Thanks @gamontoya I'm looking for object that has the License\permission\Permission\type = "localDisplay" like the example above in qa. Do you know any? Thanks |
@VivianChu I don't know of any. @GregReser do we have any? |
@VivianChu I don't think so. https://librarytest.ucsd.edu/dc/object/bd66071852 was the first use case. I can ingest that object to QA as a test. |
@GregReser - It would be great. Could you ingest it? Thanks |
@VivianChu I will. It is a big file, I'll let you know when it's done. |
@VivianChu I think something is wrong with QA Excel ingest. This video file failed to import and a different still image object also failed. I can mention this in Slack to see if anyone knows what the problem is. |
@GregReser - I can deploy the change to staging to test with the object you ingested already. I'll let you know when it's ready to view. |
@GregReser @gamontoya - The change has been deployed to staging. Could you take a look? https://librarytest.ucsd.edu/dc/object/bd66071852 Thanks |
@VivianChu Download button is gone, but I cannot play the video (either logged in as curator or as public) |
@GregReser - Does the video work for you before? My change is only about the download button. |
@GregReser - I think other video also doesn't work. https://librarytest.ucsd.edu/dc/object/bb8022051s I'll try to investigate this problem with Ops and keep you posted. |
@VivianChu Yes. it worked earlier today. I had it open in the browser for before you made the change, then I refreshed and saw the error. Could it be a different problem with files in staging? There is a problem in QA right now. |
@GregReser - the same video object worked fine in qa - http://libraryqa.ucsd.edu/dc/object/bb8022051s I tried to revert the change to see if it helps. |
@VivianChu there's a conversation about it on the Slack dams channel now |
Descriptive summary
If the user is not logged as a curator, they should should not be able to download videos for objects that are restricted to UCSD-only. This should be true for all objects, components, and sub-components.
This should be true if the object contains either:
OtherRights\permission\Permission\type = "localDisplay"
License\permission\Permission\type = "localDisplay"
Example: https://librarytest.ucsd.edu/dc/object/bd66071852
A current ingest is dependent on this issue:
https://lib-jira.ucsd.edu:8443/browse/DI-224?filter=12684
The text was updated successfully, but these errors were encountered: