Skip to content
This repository has been archived by the owner on Mar 24, 2020. It is now read-only.

Remove download function for UCSD-only video objects #461

Closed
ghost opened this issue Jun 7, 2018 · 17 comments
Closed

Remove download function for UCSD-only video objects #461

ghost opened this issue Jun 7, 2018 · 17 comments
Assignees
Labels

Comments

@ghost
Copy link

ghost commented Jun 7, 2018

Descriptive summary

If the user is not logged as a curator, they should should not be able to download videos for objects that are restricted to UCSD-only. This should be true for all objects, components, and sub-components.

This should be true if the object contains either:
OtherRights\permission\Permission\type = "localDisplay"
License\permission\Permission\type = "localDisplay"

Example: https://librarytest.ucsd.edu/dc/object/bd66071852
image

A current ingest is dependent on this issue:
https://lib-jira.ucsd.edu:8443/browse/DI-224?filter=12684

@ghost ghost added the bug label Jun 7, 2018
@gamontoya gamontoya assigned gamontoya and unassigned gamontoya Jun 7, 2018
@ghost
Copy link
Author

ghost commented Jun 18, 2018

@gamontoya do you have any idea when this might moved out of the icebox and into a sprint? The CARS licensed Chinese videos cannot be ingested and made available until the download issue is resolved.
https://lib-jira.ucsd.edu:8443/browse/DI-224

@VivianChu
Copy link
Member

@GregReser - Do you know if there is any UCSD-only video objects in qa? I'm done removing the download function for video object. I would like to deploy the change to qa for testing first. Thanks

@gamontoya
Copy link

@VivianChu All these videos in this collection: http://libraryqa.ucsd.edu/dc/collection/bb19126574

@VivianChu
Copy link
Member

VivianChu commented Jun 21, 2018

Thanks @gamontoya I'm looking for object that has the License\permission\Permission\type = "localDisplay" like the example above in qa. Do you know any? Thanks

@gamontoya
Copy link

@VivianChu I don't know of any. @GregReser do we have any?

@ghost
Copy link
Author

ghost commented Jun 21, 2018

@VivianChu I don't think so. https://librarytest.ucsd.edu/dc/object/bd66071852 was the first use case. I can ingest that object to QA as a test.

@VivianChu
Copy link
Member

@GregReser - It would be great. Could you ingest it? Thanks

@ghost
Copy link
Author

ghost commented Jun 21, 2018

@VivianChu I will. It is a big file, I'll let you know when it's done.

@ghost
Copy link
Author

ghost commented Jun 21, 2018

@VivianChu I think something is wrong with QA Excel ingest. This video file failed to import and a different still image object also failed. I can mention this in Slack to see if anyone knows what the problem is.

@VivianChu
Copy link
Member

@GregReser - I can deploy the change to staging to test with the object you ingested already. I'll let you know when it's ready to view.

@VivianChu
Copy link
Member

@GregReser @gamontoya - The change has been deployed to staging. Could you take a look? https://librarytest.ucsd.edu/dc/object/bd66071852 Thanks

@ghost
Copy link
Author

ghost commented Jun 21, 2018

@VivianChu Download button is gone, but I cannot play the video (either logged in as curator or as public)
image

@VivianChu
Copy link
Member

@GregReser - Does the video work for you before? My change is only about the download button.

@VivianChu
Copy link
Member

@GregReser - I think other video also doesn't work. https://librarytest.ucsd.edu/dc/object/bb8022051s I'll try to investigate this problem with Ops and keep you posted.

@ghost
Copy link
Author

ghost commented Jun 21, 2018

@VivianChu Yes. it worked earlier today. I had it open in the browser for before you made the change, then I refreshed and saw the error. Could it be a different problem with files in staging? There is a problem in QA right now.

@VivianChu
Copy link
Member

@GregReser - the same video object worked fine in qa - http://libraryqa.ucsd.edu/dc/object/bb8022051s I tried to revert the change to see if it helps.

@ghost
Copy link
Author

ghost commented Jun 21, 2018

@VivianChu there's a conversation about it on the Slack dams channel now

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants