Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error occurs when Link elements with reference to the external URL #15

Open
ucym opened this issue Feb 17, 2014 · 1 comment
Open

Error occurs when Link elements with reference to the external URL #15

ucym opened this issue Feb 17, 2014 · 1 comment

Comments

@ucym
Copy link
Owner

ucym commented Feb 17, 2014

No description provided.

@redmunds
Copy link

I think I'm seeing the same problem. I have my project open to the Brackets repo. Every 20 seconds I see this set of messages:

Detect external changes: C:/Users/redmunds/dev/github/brackets/node_modules/grunt-contrib-less/node_modules/less/test/browser/css/urls.css (CSSCache.js:98)
Detect external changes: C:/Users/redmunds/dev/github/brackets/node_modules/grunt-contrib-less/node_modules/less/test/browser/css/relative-urls/urls.css (CSSCache.js:98)
Detect external changes: C:/Users/redmunds/dev/github/brackets/node_modules/grunt-contrib-less/node_modules/less/test/browser/css/rootpath/urls.css (CSSCache.js:98)
Detect external changes: C:/Users/redmunds/dev/github/brackets/node_modules/grunt-contrib-less/node_modules/less/test/browser/css/rootpath-relative/urls.css (CSSCache.js:98)
GET http://localhost:8081/test/browser/less/modify-this.css  (jquery-2.1.0.min.js:3)
GET http://localhost:8081/test/browser/less/modify-again.css  (jquery-2.1.0.min.js:3)
GET http://localhost:8081/test/browser/less/imports/modify-this.css  (jquery-2.1.0.min.js:3)
GET http://localhost:8081/test/browser/less/imports/modify-again.css  (jquery-2.1.0.min.js:3)
GET https://github.com/modify-this.css 404 (Not Found) (jquery-2.1.0.min.js:3)
GET https://github.com/modify-again.css 404 (Not Found) (jquery-2.1.0.min.js:3)
GET https://github.com/cloudhead/imports/modify-this.css 404 (Not Found) (jquery-2.1.0.min.js:3)
GET https://github.com/cloudhead/imports/modify-again.css 404 (Not Found) (jquery-2.1.0.min.js:3)

For the urls.css case, it has @import "http://localhost:8081/test/browser/less/modify-this.css";, so I suspect it may be the same issue. Looking at the code, it seems that this._lastUpdateCheck is never set. Setting that value in the failure case should at least limit the error to only showing once.

Also, Brackets now supports File Watchers, so your should be able to rewrite this more efficiently to remove the polling.

FYI, this was originally reported at adobe/brackets#6439.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants