Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S09.04 -> TODO 18/34 -> Wrong order #40

Closed
rsd-raul opened this issue Mar 2, 2017 · 5 comments
Closed

S09.04 -> TODO 18/34 -> Wrong order #40

rsd-raul opened this issue Mar 2, 2017 · 5 comments

Comments

@rsd-raul
Copy link

rsd-raul commented Mar 2, 2017

This is not really a proper issue, but an ordering problem, the TODO number 18 in MainActivity reads:

// TODO (18) Call the showLoading method

While the TODO number 34 reads:

// TODO (34) Create a method called showLoading that shows the loading indicator and hides the data

Creating a minor name/order confusion. As the showLoading method doesn't have any dependency the TODO 34 can be moved to the position 18 and all the other TODO's indexes increased by 1 without problems.

Ps: Not sure if you guys prefer a pull request for such a detail, if so, let me know.

@gabor-meszaros
Copy link

I agree. I have just wanted to report this issue.

@jwill
Copy link

jwill commented Nov 24, 2017

PR would be best.

@intrepidOlivia
Copy link

This issue is still open. Is it up to students to initiate a pull request?

@jwill
Copy link

jwill commented Mar 18, 2018

Thanks for the interest but I'll be closing this issue.

@jwill jwill closed this as completed Mar 18, 2018
@intrepidOlivia
Copy link

Generally throughout the course, the order of the TODOs will have the student write a method before referencing it. Is there any particular reason not to follow that pattern here? It's confusing to be instructed to call a method that doesn't exist yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants