-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Child breadcrumb with empty path is ignored and replaces parent #44
Comments
To make this a little more visual, with the code changes referenced, I see this: And I am expecting to see this: Whilst prepping those screenshots, I noticed that whilst I could get it to display Either value would probably work for us, but it seems logical that both should (with the child taking precedence) |
Also, sorry for keep finding problems 😄 If it's any consolation, I'm invested in flushing them all out because it's a library I intend to use in multiple projects and recommend to others 👍 |
@chad-smith I really appreciate you for finding and reporting these subtle bugs - I have fixed this and also covered it in a test so that it won't break again. Fix available with version 6.2.0 🎉 https://github.com/udayvunnam/xng-breadcrumb/releases/tag/v6.2.0 |
i having a issue, when a wrapp xng-breadcrumb inside another component(app-custom-breadcrumb) and and this componet is used with a ngIf sentence(to know device resolution), its seems got a empty route |
@nativeforest your issue is fixed with xng-breadcrumb@6.8.1 |
I have found some odd behaviour when defining empty paths, it's quite fiddly to explain in text, so I have altered the demo site to reproduce my findings.
If you apply the changes in chad-smith/xng-breadcrumb@master...demo-data-bug you will find that neither of the breadcrumbs being set are used.
After a bit of poking around, I found the following:
data: { breadcrumb: ...}
makes no differencedata: { breadcrumb: ...}
resolves the issuedata: {}
_ in the module causes the issue!Scenario 3 is why the project I'm using breadcrumbs on has been seeing the problem (we use the data attributes frequently for permissions).
NB: If you deviate from an empty path, you will see both breadcrumbs as expected.
I thought this might be related to #25 because using the 'hack' that was described there also seems to work.
The text was updated successfully, but these errors were encountered: