Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

The breadcrumb cannot be used on ES5 #65

Closed
dedrazer opened this issue Dec 9, 2020 · 15 comments
Closed

The breadcrumb cannot be used on ES5 #65

dedrazer opened this issue Dec 9, 2020 · 15 comments
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@dedrazer
Copy link
Contributor

dedrazer commented Dec 9, 2020

馃悶 Bug report

Using the latest version of this package requires changing the project target version to ES2015.

Description

Is it possible to change the project target to ES5?

馃敩 Minimal Reproduction

yarn the breadcrumb on an ES5 solution.

馃捇Your Environment

Angular Version:

9

Scully Version:

N/A

馃敟 Exception or Error

"ERROR in getInternalNameOfClass() called on a non-ES5 class: expected BreadcrumbItemDirective to have an inner class declaration"

@dedrazer dedrazer added the bug Something isn't working label Dec 9, 2020
@udayvunnam
Copy link
Owner

@dedrazer does this work with previous version of xng-breadcrum. Please provide last version where you get it to work with ES5

@dedrazer
Copy link
Contributor Author

dedrazer commented Dec 9, 2020

I had tried version 4 and it worked without hassle, but I did not test version 5.

@dedrazer
Copy link
Contributor Author

dedrazer commented Dec 9, 2020

it seems version 5 is also good

@dedrazer
Copy link
Contributor Author

dedrazer commented Dec 9, 2020

6.2 works also. The issue started with 6.3

@udayvunnam
Copy link
Owner

With 6.3 we upgraded @angular/cli to version 11. I wonder when there is no breaking change from Angular why this happens.

For a long time, we have been using "target": "es2015". I wonder what's causing an issue now

@dedrazer
Copy link
Contributor Author

The error message points toward BreadcrumbItemDirective, that's all I know.

@dedrazer
Copy link
Contributor Author

do you reckon this will get fixed? we would like to keep using the latest version of xng on our application

@udayvunnam
Copy link
Owner

@dedrazer Thanks for showing effort in keeping the library up-to-date. Have you tried this solution https://stackoverflow.com/a/63727427

@dedrazer
Copy link
Contributor Author

@udayvunnam, yes I have. It works locally but on the CI Pipeline the error is still thrown.

@dedrazer
Copy link
Contributor Author

dedrazer commented Jan 6, 2021

I wouldn't like to be bothersome, it would be really nice to have a solution for this on ES5. In 6.2 I cannot get the alias working for some reason and I cannot access the changes I made in 6.4.0.

@udayvunnam
Copy link
Owner

@dedrazer This might be a minor TS target version change. I will check this soon.

@dedrazer
Copy link
Contributor Author

dedrazer commented Jan 7, 2021

thanks @udayvunnam, I appreciate it!

@stale
Copy link

stale bot commented Mar 2, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Mar 2, 2021
@udayvunnam
Copy link
Owner

Not stale

@udayvunnam udayvunnam removed the wontfix This will not be worked on label Mar 2, 2021
@stale
Copy link

stale bot commented Apr 1, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Apr 1, 2021
@stale stale bot closed this as completed Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants