-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
The breadcrumb cannot be used on ES5 #65
Comments
@dedrazer does this work with previous version of xng-breadcrum. Please provide last version where you get it to work with ES5 |
I had tried version 4 and it worked without hassle, but I did not test version 5. |
it seems version 5 is also good |
6.2 works also. The issue started with 6.3 |
With 6.3 we upgraded @angular/cli to version 11. I wonder when there is no breaking change from Angular why this happens. For a long time, we have been using "target": "es2015". I wonder what's causing an issue now |
The error message points toward BreadcrumbItemDirective, that's all I know. |
do you reckon this will get fixed? we would like to keep using the latest version of xng on our application |
@dedrazer Thanks for showing effort in keeping the library up-to-date. Have you tried this solution https://stackoverflow.com/a/63727427 |
@udayvunnam, yes I have. It works locally but on the CI Pipeline the error is still thrown. |
I wouldn't like to be bothersome, it would be really nice to have a solution for this on ES5. In 6.2 I cannot get the alias working for some reason and I cannot access the changes I made in 6.4.0. |
@dedrazer This might be a minor TS target version change. I will check this soon. |
thanks @udayvunnam, I appreciate it! |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Not stale |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
馃悶 Bug report
Using the latest version of this package requires changing the project target version to ES2015.
Description
Is it possible to change the project target to ES5?
馃敩 Minimal Reproduction
yarn the breadcrumb on an ES5 solution.
馃捇Your Environment
Angular Version:
9
Scully Version:
N/A
馃敟 Exception or Error
"ERROR in getInternalNameOfClass() called on a non-ES5 class: expected BreadcrumbItemDirective to have an inner class declaration"
The text was updated successfully, but these errors were encountered: