Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breadcrumb not refreshed when calling breadcrumbService.set() #74

Closed
gilsdav opened this issue Feb 24, 2021 · 1 comment
Closed

Breadcrumb not refreshed when calling breadcrumbService.set() #74

gilsdav opened this issue Feb 24, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@gilsdav
Copy link

gilsdav commented Feb 24, 2021 •
edited

馃悶 Bug report

Description

I can see your breadcrumb is not observable from the store to the html.

xng-breadcrumb/libs/xng-breadcrumb/src/lib/breadcrumb.component.ts

Line 92 in f63924f

this.breadcrumbs = breadcrumbs

This is not compatible with full of partial "onPush" angular apps.

this.breadcrumbs needs to be an observable (no subscribe in ngOnInit) and use the pipe async into the HTML.

馃捇Your Environment

Angular: 11.2.2
Breadcrumb: 6.6.0
@gilsdav gilsdav added the bug Something isn't working label Feb 24, 2021
@anthonythiry anthonythiry mentioned this issue Feb 24, 2021
Merged
3 tasks
@udayvunnam
Copy link
Owner

Thanks for raising the issue @gilsdav!

馃帀 The fix is included in version 6.6.1 馃帀

The release is available on - https://www.npmjs.com/package/xng-breadcrumb/v/6.6.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@udayvunnam @gilsdav