Option to enable/disable Mention / ComboBox Plugin with Predicate

[OliverWales]

I'm implementing a feature similar to Notion's Type '/' for commands. The Combobox plugin seems to be a good fit for this, except that I'd only like to enable this feature if the slash is at the start of a line.

At the moment, I can get close by overriding the onChangeCombobox function with one that is almost identical but inserts the following additional quick return logic:

const blockPath = getBlockAbove(editor)?.[1];
if (!blockPath || !isStartPoint(editor, range.anchor, blockPath)) continue;

But unfortunately I also use the mention plugin for user mentions and adding the above custom combobox plugin seems to break that plugin, as it closes it whenever it is not at the start of a line 🙃

As I see it, the most ideal solution is that the mention and combobox plugins have an additional optional property of enabled or disabled that allows you to pass some predicate per-plugin as to whether it should open.

What do you reckon? Happy to look into providing a PR if it would be useful for others 🙂

[zbeyens]

PRs for additional options are very appreciated, the slash command is in the roadmap so your contribution will help a lot!

[OliverWales]

Cool, will give it a go!

In terms of API, I'm thinking of adding one of the following options as an optional plugin option:

• A onlyIfEmptyBlock of type boolean that implements the logic directly
• A enable prop of type (editor: Editor) => boolean so you can specify custom logic
• A disable prop, as above but inverted

Which do you reckon is best?

[zbeyens]

Let's name it query: true -> open, false -> closed

[OliverWales]

Added in #2166