Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More lenient external dependency requirements #1469

Closed
jkillian opened this issue Mar 30, 2022 · 3 comments · Fixed by #1500
Closed

More lenient external dependency requirements #1469

jkillian opened this issue Mar 30, 2022 · 3 comments · Fixed by #1500

Comments

@jkillian
Copy link

Description

We've just started trying out plate and so far it's been great! One small thing I noticed though was that many of the plate packages have exact external dependency versions hardcoded, for example, in core:

"clsx": "1.1.1",
"jotai": "1.5.3",
"lodash": "4.17.21",
"use-deep-compare": "1.1.0",
"zustand": "3.7.0"

This unfortunately can really bloat bundlesize because it means that plate can't share a version of a dependency with other packages that require the same dependency, and the dependency ends up getting installed and bundled multiple times.

Would you be willing to make all the dependency versions accept patch and minor releases above what you currently have? So "lodash": "4.17.21", -> "lodash": "^4.17.21",for eample?

Thanks for the consideration, and apologies if this isn't really a "bug", wasn't sure where to file it!

@jkillian jkillian added the bug Something isn't working label Mar 30, 2022
@zbeyens
Copy link
Member

zbeyens commented Mar 30, 2022

Sure, let's do that

@zbeyens zbeyens added core vendor and removed bug Something isn't working labels Mar 30, 2022
@odusseys
Copy link

is there a plan to do this soon / to make some packages modular ? Right now Plate adds 600kB to bundle size which is huge ; for example plate-code-block adds 100k in dependencies (prism) even if not used ; and the dependency on juice adds over 250k by itself

@zbeyens
Copy link
Member

zbeyens commented Apr 28, 2022

If bundle size matters, you should install individual packages instead of @udecode/plate

As for this issue, this is not my priority yet so PR's welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants