Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing default styles #230

Closed
kukagg opened this issue Jul 26, 2020 · 2 comments
Closed

Removing default styles #230

kukagg opened this issue Jul 26, 2020 · 2 comments
Labels
feature request question / support Further information is requested

Comments

@kukagg
Copy link

kukagg commented Jul 26, 2020

First, I want to thank @zbeyens for this repo. A great work!

I started going through the plugins and found out that there are default styles. I wonder what’s the reason behind implementing it? A case for image element here.

It seems like the only way is to fork the repo and clean these styles/sync going forward but I thought I’d clear it up before doing that. Thanks in advance and much respect!

@zbeyens
Copy link
Member

zbeyens commented Jul 26, 2020

Hi, thanks a lot!

Good question, it's not clearly documented in Storybook but here you have a complete guide.

So you want to use ImageElementBase that has no default styles, in the component option. I didn't try yet but let me know if it does not work!

You also have StyledElement for single tag components. For more custom, just pass one of your created component.

As for the why, I find it interesting to (slowly) turn this library as a "WISIWYG" design system, as it targets a lot of front-end "beginners".

Then for the future of this lib we can debate on (e.g. for ImageElement):

  1. using ImageElement as default component (as it is now).
  2. using ImageElementBase as default component and let the consumer import and pass ImageElement as component option.

@zbeyens zbeyens added feature request question / support Further information is requested labels Jul 26, 2020
@zbeyens
Copy link
Member

zbeyens commented Dec 8, 2020

Let's track this in #363

@zbeyens zbeyens closed this as completed Dec 8, 2020
@udecode udecode locked and limited conversation to collaborators Feb 22, 2021

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
feature request question / support Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants