-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: renames lambda property to lambdaFunction #277
Conversation
WalkthroughThe modification involves a straightforward, yet significant renaming within the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- lib/index.ts (3 hunks)
Additional comments: 6
lib/index.ts (6)
- 150-150: Renaming the
lambda
property tolambdaFunction
is a clear and effective way to resolve the naming conflict with Python reserved keywords. This change is consistent with the PR's objective and should not introduce any issues as long as all references to the old property name are updated accordingly.- 226-226: The update to use
lambdaFunction
in theensureLambda
method call is correctly implemented. This change aligns with the renaming strategy and ensures that the property is correctly initialized.- 254-254: Correctly passing the
lambdaFunction
's ARN to theCustomResource
as theserviceToken
ensures that the custom resource continues to function as intended with the renamed property. This is a crucial update that maintains the integrity of the resource creation process.- 260-260: Granting encryption and decryption permissions to the
lambdaFunction
for the KMS key is correctly implemented. This change is part of the necessary updates following the property renaming and ensures that the lambda function has the appropriate permissions to operate with the KMS key.- 266-266: Similarly, granting permissions to the
lambdaFunction
for the private KMS key is correctly handled. This ensures that the lambda function can encrypt and decrypt using the private key, maintaining the functionality of theKeyPair
class.- 272-272: Granting permissions to the
lambdaFunction
for the public KMS key is also correctly implemented. This ensures that the lambda function can encrypt and decrypt using the public key, which is essential for the operation of theKeyPair
class.
Even though this never was a real problem to my knowledge, jsii alwys complained about the use of the keyword
lambda
:Therefore we now rename it to
lambdaFunction
.This is a potential breaking change. If you used the exposed keyPair property
lambda
it needs to be changed tolambdaFunction
.