-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds fingerprint and public key format as resource properties #291
Conversation
WalkthroughThe recent updates introduce enhancements to key pair management functionalities. These changes include adding new fields ( Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files selected for processing (3)
- lambda/index.ts (4 hunks)
- lib/index.ts (3 hunks)
- test/lib/test-stack.ts (1 hunks)
Additional comments: 6
lib/index.ts (3)
- 200-208: The addition of
keyPairFingerprint
andpublicKeyFormat
properties to theKeyPair
class is well-implemented and enhances the class's functionality.- 277-277: Initialization of
publicKeyFormat
in the constructor based on providedprops
is correctly implemented. The handling ofkeyPairFingerprint
is appropriately deferred to be set from key attributes.- 332-332: Setting
keyPairFingerprint
from key attributes in the constructor ensures the property reflects the actual AWS resource state.lambda/index.ts (3)
- 183-183: Adding
KeyFingerprint
andKeyPairFingerprint
to the response values in thecreateKeyPair
function enhances security and identification for key pairs. This is a valuable addition.Also applies to: 207-207
- 234-234: Including
KeyPairFingerprint
in the response values of theupdateKeyPair
function ensures consistency and provides valuable identification information post-update.- 180-186: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [1-1]
The summary mentions the removal of setting
KeyPairName
in thedeleteKeyPair
function, which likely refers to a cleanup of unnecessary code. This change, while not visible in the provided code, aligns with best practices by avoiding redundant operations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- test/lib/test-stack.ts (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- test/lib/test-stack.ts
On a keypair, now you can access
.publicKeyFormat
and.keyPairFingerprint
.