Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand echo_current_song setting #1

Open
louis6321 opened this issue Mar 15, 2019 · 2 comments
Open

Expand echo_current_song setting #1

louis6321 opened this issue Mar 15, 2019 · 2 comments
Labels
enhancement New feature or request low-prio

Comments

@louis6321
Copy link

Currently "echo_current_song" only allows for true/false.
It would be good if it had something like "commands_only" meaning that it will echo if it's the result of a command in chat (e.g. !skip), but it won't echo by itself at the end of a track.
@udoprog udoprog added the enhancement New feature or request label Mar 16, 2019
@udoprog
Copy link
Owner

udoprog commented Mar 19, 2019

This one is a bit more involved since the current notification flow is asynchronous. I.e. the playback component is unaware of what causes certain commands to be sent to it.

@udoprog
Copy link
Owner

udoprog commented Jun 8, 2019 •
edited

Might look into more settings in the future.

@udoprog udoprog closed this as completed Jun 8, 2019
@udoprog udoprog reopened this Jun 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request low-prio
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@udoprog @louis6321