Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Material] Cannot close dialog using ESC #831

Closed
mpschaeuble opened this issue Aug 7, 2018 · 2 comments
Closed

[Material] Cannot close dialog using ESC #831

mpschaeuble opened this issue Aug 7, 2018 · 2 comments

Comments

@mpschaeuble
Copy link

I'm submitting a


[x] Bug / Regression
[ ] Feature Request / Proposal
[x] Question

I'm using


NG Dynamic Forms Version: `6.0.8`

[ ] Basic UI
[ ] Bootstrap UI  
[ ] Foundation UI
[ ] Ionic UI
[ ] Kendo UI
[x] Material  
[ ] NG Bootstrap
[ ] Prime NG

Description

Angular material's dialog implementation listens to keydown event to close the dialog when the escape key is pressed (https://github.com/angular/material2/blob/master/src/lib/dialog/dialog-ref.ts). This works perfectly fine when the focus is in an input field of a manually created form. If the form is created using ng-dynamic-forms, this seems not to work anymore.
Is the library somehow catching events and not properly propagating them further? I was looking at the code but couldn't find the reason why this is not working.

@Karamuto
Copy link
Collaborator

Karamuto commented Aug 8, 2018

Hello @mpschaeuble,

I sadly couldn't recreate your problem.

Could you provide a minimal example with the problem? A list of ther 3rd party libraries in use could also provide helpful information.

@mpschaeuble
Copy link
Author

@Karamuto I really tried hard to reproduce the issue in a stackblitz, but wasn't able to do so. At the same time, I tried to reduce my application to a bare minimum, but the issue remained :-(
It seems to be some local issue and therefore, I think this issue can be closed.
Sorry for wasting your time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants