Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying mapping distance for POIs #170

Closed
Rikuoja opened this issue Aug 30, 2021 · 0 comments · Fixed by #171
Closed

Allow specifying mapping distance for POIs #170

Rikuoja opened this issue Aug 30, 2021 · 0 comments · Fixed by #171

Comments

@Rikuoja
Copy link
Contributor

Rikuoja commented Aug 30, 2021

Description of the bug

Currently, get_node_ids can be called with the optional mapping_distance parameter, but set_pois does not use this parameter at https://github.com/UDST/pandana/blob/dev/pandana/network.py#L680. This results in very far-away POI nodes always being mapped to the closest point in the network.

Mostly this is an issue in cities with waterways or islands. All the POIs on the other side of the waterway or islands will be mapped to closest network point, no matter how far away from the network they are.

Therefore, would be nice to be able to specify mapping_distance when setting POIs, so POIs that are too far will be discarded from the POI set.

Currently, this results in spurious zero distances to lots of POIs at the outermost nodes in e.g. a cape, since all the POIs in any islands will be mapped to this point:
image

Network data (optional)

Any network that has POIs far from network nodes.

@Rikuoja Rikuoja changed the title Allow specifying mapping distance for POIS Allow specifying mapping distance for POIs Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant