Add WP_STATELESS_SKIP_ACL_SET for skip ACL set for GCS #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukefly
approved these changes
Feb 8, 2023
|
Hello @vsychov Thank you for your involving. We are going to release this feature with new version of WP-Stateless. |
ewsopp
requested review from
planv and
balexey88
and removed request for
planv
balexey88
approved these changes
Oct 2, 2023
Fix logic of processing new WP_STATELESS_SKIP_ACL_SET constant
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
currently this plugin fails when GCS bucket created with uniform bucket-level access, that not support ACL. So plugin cannot insert legacy ACL for an object when uniform bucket-level access is enabled.
This PR add
WP_STATELESS_SKIP_ACL_SETconstant, that fix it.Solve #521