New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility with sktime v0.6.1 #87
Compatibility with sktime v0.6.1 #87
Conversation
Hi, thanks! Currently, there's just the one test failing because of Keras. |
@Riyabelle25 as discussed, I suggest adding the pytest decorator to see if this test fails for all networks or only one of them. |
Going to go through this, today with @jnrusson1, as I'd like to get this PR'd in before dev days next week. Really great job @Riyabelle25 looks decent. |
@jnrusson1 noticed a issue and raise this in the #87 issue. I haven't had a chance to verify this, but @Riyabelle25 if you wouldn't mind taking a closer look that would be very helpful :) |
I've fixed linting and parametrized the networks to see which fail. Thanks, @ABostrom, @jnrusson1! |
|
@Riyabelle25 it shouldn't be necessary to compile sktime as we provide precompiled wheels for it, not sure why it tries to build it from source. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll try this out
Reference Issues/PRs
Fixes #74 , #76
What does this implement/fix? Explain your changes.
This PR fixes issues #74 and #76 by updating sktime references in the code to that of
sktime v0.6.1
. Hence this resolves compatibility issues withsktime v0.6.1
, bringingsktime_dl
up-to-date with the latest version of sktime.It also updates deprecated Keras code to resolve some of the build failures on running
Pytest
.Tested by:
After this I ran
pytest
in the root directory, and confirmed that no tests are failing due to incompatibility with sktime.Rather they are associated with version incompatibilities of Keras, Tensorflow, and Numpy, and I debugged by updating deprecated Keras code.