Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard dependency on Phoenix 1.3.2 #4

Closed
tmjoen opened this issue Aug 9, 2019 · 7 comments
Closed

Hard dependency on Phoenix 1.3.2 #4

tmjoen opened this issue Aug 9, 2019 · 7 comments

Comments

@tmjoen
Copy link

tmjoen commented Aug 9, 2019

Failed to use "phoenix" (versions 1.4.0 to 1.4.9) because
  guardian_phoenix (version 2.0.0) requires 1.3.2
  phoenix_live_reload (version 1.2.1) requires ~> 1.4
  mix.exs specifies ~> 1.4

Looks like an oversight in mix.exs:

{:phoenix, "1.3.2"},

@yordis
Copy link
Member

yordis commented Aug 9, 2019

Definitely shouldn't be 1.3.2, but I am not sure about 1.4 Phoenix since they had some breaking changes.

Would you mind to take the lead testing it with Phoenix 1.4?

@gil-air-may
Copy link

Any news on this issue?

@doomspork
Copy link
Member

@tmjoen or @gil-air-may have you had a chance to test this with 1.4?

@yordis we could release a patch version with the dep moved to 1.3. Thoughts?

@yordis
Copy link
Member

yordis commented Sep 22, 2019

Yeah, we could at least use ~> 1.3 instead

@tmjoen
Copy link
Author

tmjoen commented Sep 23, 2019

Seems to work fine with 1.4 in my app. I don't use Permissions though, so YMMV.

@yordis
Copy link
Member

yordis commented Sep 23, 2019

@tmjoen are you getting any warnings? I think we need to fix some warnings.

@yordis
Copy link
Member

yordis commented Sep 23, 2019

I released 2.0.1, using ~> 1.3 instead.

Let me know if that works or if I have to add ~> 1.4 as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants