New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add token base workflow #50
Comments
I will be more than happy to contribute on this but I need directions, specially thinking on fallback |
@scrogson but the idea is actually expand I understand how to accomplish the task but I think is better to add that feature. I think is a perfect place and it will help a lot of people. |
@yordis i agree. I need this feature to jump on ueberauth, and leave Rails... |
@tugal the ticket is closed so 😢 |
I'd like to attack this feature in the very near future. I'm seeing this come up as an issue more and more. My focus atm is getting guardian 1.0 out but I'm hearing this issue loud and clear. One thing I'm not sure about is how to get this into ueberauth base rather than delegating it out to the individual strategies. Is there a behaviour we can define that would provide enough to kick this off or do you folks think that strategies should look after it? |
@hassox if you are focus on Guardian I can help over this side.
Side notes, |
@hassox : Why not create another optionnal method "validate_token" (ina ddition to exiting ones : request and callback), where statégies are responsible to implement. In my point of view, only stratégies know how to validate their tokens... Nice to hean that this feature still open.. |
Moved to #61 |
Related to #20
Add a method that takes a
auth token code
that will be used for fetch the user info data. Some work done (https://github.com/yordis/ueberauth_facebook/blob/add-token-based-workflow/lib/ueberauth/strategy/facebook.ex#L56). I would say that it will be better to actually use a different name for it.This method do not required any
Conn
or anything related toPlug
. Normally will be called manually with some token.Example:
Use Case
When the OAuth workflow happens in the clients (like Mobile devices using the native SDKs), the
access token
will be use for authenticate the user instead of the current OAuth2 workflow.Thought
There is some overlapping between both workflows (See: https://github.com/yordis/ueberauth_facebook/commit/c4246cf56bf8ffad61297fc88ea6cdee36dfeb69) As you can see the differences between the workflows is that in one of them the
user data
is inside theConn
.This is a full implementation of the token based workflow where you will find the overlaps between workflows.
Please read the comments on the code
cc: @doomspork
The text was updated successfully, but these errors were encountered: