You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Description
We've started to see an error occasionally in production that causes the Hocuspocus server to crash on a websocket error. Specifically, the error is:
Steps to reproduce the bug
Unfortunately I'm not able to reproduce this yet. I tried sending some invalid websocket payloads to Hocuspocus but those appear to be filtered correctly.
Expected behavior
I would not expect ANY invalid websocket message from a single client to crash the server but rather log an error and close the offending connection.
Environment?
operating system: NodeJS 16
hocuspocus version: 1.0.0-alpha.100
The text was updated successfully, but these errors were encountered:
Description
We've started to see an error occasionally in production that causes the Hocuspocus server to crash on a websocket error. Specifically, the error is:
It appears that
ws
will catch this and close the connection if ws.on('error', cb) is defined, but I don't see that happening in the Hocuspocus source.Steps to reproduce the bug
Unfortunately I'm not able to reproduce this yet. I tried sending some invalid websocket payloads to Hocuspocus but those appear to be filtered correctly.
Expected behavior
I would not expect ANY invalid websocket message from a single client to crash the server but rather log an error and close the offending connection.
Environment?
1.0.0-alpha.100
The text was updated successfully, but these errors were encountered: