We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Description The server package does not export the new DirectConnection class type.
server
DirectConnection
Steps to reproduce the bug
import { DirectConnection } from "@hocuspocus/server"
Expected behavior The type should be available, in cases where you want to be able to pass around the connection object.
Additional context I forgot to add it to the index.ts file when I made the PR for DirectConnection.
The text was updated successfully, but these errors were encountered:
2a20d7a
makes sense! I've just aded the typings 🥳
Sorry, something went wrong.
DirectConnection class is still not exported in index.ts file.
index.ts
Currently in 2.7.1:
import { DirectConnection } from "@hocuspocus/server" // this is actual DirectConnectionInterface, not the DirectConnection class
if using in Node.js TypeScript "module": "commonjs", there is a workaround, we can directly import from DirectConnection.ts file
"module": "commonjs"
DirectConnection.ts
import { DirectConnection } from '@hocuspocus/server/dist/packages/server/src/DirectConnection';
But in Node.js TypeScript "module": "NodeNext", there is no way to import DirectConnection class type.
"module": "NodeNext"
DirectConnectionInterface
types.ts
export * from './DirectConnection.js'
these changes can both export DirectConnection class and interface types.
janthurau
No branches or pull requests
Description
The
server
package does not export the newDirectConnection
class type.Steps to reproduce the bug
Expected behavior
The type should be available, in cases where you want to be able to pass around the connection object.
Additional context
I forgot to add it to the index.ts file when I made the PR for DirectConnection.
The text was updated successfully, but these errors were encountered: