Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 7.4 check for self closing tag leads to exception #10

Closed
mmachatschek opened this issue Feb 1, 2022 · 0 comments · Fixed by #11
Closed

PHP 7.4 check for self closing tag leads to exception #10

mmachatschek opened this issue Feb 1, 2022 · 0 comments · Fixed by #11

Comments

@mmachatschek
Copy link

With PHP 7.4 there is an exception when running the tests because of some unexpected behaviour with rendering self closing tags.

tiptap-php/src/DOMSerializer.php

Line 225 in 7f1a6c8

private function isSelfClosing($tag)

https://github.com/mmachatschek/tiptap-php/runs/5019212800?check_suite_focus=true

While debugging, I found out that the $tag passed to isSelfClosing() contains html attributes of e.g. the rel attribute of an a-tag
@mmachatschek mmachatschek mentioned this issue Feb 1, 2022
Closed
7 tasks
@hanspagel hanspagel linked a pull request Feb 2, 2022 that will close this issue
Add PHP 7.4 support #11
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add PHP 7.4 support ueberdosis/tiptap-php
1 participant
@mmachatschek