Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image upload API? #138

Closed
lewiswharf opened this issue Dec 16, 2018 · 8 comments
Closed

Image upload API? #138

lewiswharf opened this issue Dec 16, 2018 · 8 comments

Comments

@lewiswharf
Copy link

Awesome approach to a WYSIWYG editor. Is there a plan to incorporate an image upload API?

What's the current workaround people are using?

@hanspagel
Copy link
Contributor

hanspagel commented Dec 16, 2018

There are so many ways to do an upload integration so it's hard to define one in the core. I think the way to go is to build extensions. E.g. tiptap-s3-upload

@lewiswharf
Copy link
Author

I hear you. I didn't know if there was a best practice or community followed approach.

@ilicmarko
Copy link

Please search before posting an issue. Duplicate of #89

@lewiswharf
Copy link
Author

Thanks @ilicmarko and I already saw the issue and your response prior to posting. I'm not asking the same question. Nonetheless, I appreciate your contribution!

As a reminder, I would like to know if there's going to be an image upload API at some point…

@ilicmarko
Copy link

ilicmarko commented Dec 16, 2018

What do you consider an "image upload API"? Because there is an image API provided by Tiptap, which is enough to insert an image. Tiptap can't provide any other API more universally.

As @hanspagel said, you would need to make API for each service S3, Cloudinary, Imgur etc... Also, make it somehow for the custom endpoints. This is why you have the image command, you send it the URL and it will insert the image, editor shouldn't care how, where you got the URL/base64 string.

@hanspagel
Copy link
Contributor

We should probably set up a documentation to answer common questions like this. I'll discuss it with @philippkuehn. Until then I think we're done here. 🤓

@slava-vishnyakov
Copy link

For people coming here from Google looking how to upload the image: How to upload dropped images with TipTap editor to the server

@fdrissi
Copy link

fdrissi commented Sep 12, 2021

I have created this gist, you can find how I did it with react. I am leaving this here if anyone needs it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants