Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the process of pasting and parsing, if one '@xxx' fails to parse, then all '@xxx' pasted this time will not be parsed #3528

Closed
1 of 2 tasks
jinjinyun opened this issue Dec 12, 2022 · 1 comment
Labels
Type: Bug The issue or pullrequest is related to a bug

Comments

@jinjinyun
Copy link

What’s the bug you are facing?

@tiptap/core/src/PasteRule.ts

line 150
const success = handlers.every(handler => handler !== null)

if one '@xxx' fails to parse, all TR will be discarded。

Delete this judgment and it can work.
Maybe this judgment is useless?

Which browser was this experienced in? Are any special extensions installed?

Microsoft Edge
版本 107.0.1418.35 (正式版本) (x86_64)

How can we reproduce the bug on our side?

Can you provide a CodeSandbox?

No response

What did you expect to happen?

@tiptap/core/src/PasteRule.ts

line 150
const success = handlers.every(handler => handler !== null)

----》
const success = handlers

Anything to add? (optional)

No response

Did you update your dependencies?

  • Yes, I’ve updated my dependencies to use the latest version of all packages.

Are you sponsoring us?

  • Yes, I’m a sponsor. 💖
@jinjinyun jinjinyun added the Type: Bug The issue or pullrequest is related to a bug label Dec 12, 2022
@jinjinyun
Copy link
Author

#2368 中描述了这么做的原因,设计如此,已经通过重写nodePasteRule 方法解决了我的需求,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug The issue or pullrequest is related to a bug
Projects
None yet
Development

No branches or pull requests

1 participant