Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accepting YouTube "shorts" urls #3582

Closed
1 task
enkia opened this issue Dec 29, 2022 · 2 comments · Fixed by #4490
Closed
1 task

Accepting YouTube "shorts" urls #3582

enkia opened this issue Dec 29, 2022 · 2 comments · Fixed by #4490
Labels
Info: Stale The issue or pullrequest has not been updated in a while and might be stale Type: Feature The issue or pullrequest is a new feature

Comments

@enkia
Copy link

enkia commented Dec 29, 2022

What problem are you facing?

Ensure that users can provide YouTube short urls as well.

ie https://www.youtube.com/shorts/1H5UPEnzLkQ

What’s the solution you would like to see?

A slight change to the regex would solve the issue.

What alternatives did you consider?

Currently using a custom extension.

Anything to add? (optional)

Changing line 70 in the extension's utils adds shorts url support:

const videoIdRegex = /(?:v=|shorts\/)([-\w]+)/gm

I'd submit a pull request, but it's such a tiny change and the contributing doc said to submit ideas first.

Are you sponsoring us?

  • Yes, I’m a sponsor. 💖
@enkia enkia added the Type: Feature The issue or pullrequest is a new feature label Dec 29, 2022
@github-actions
Copy link

This issue is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Info: Stale The issue or pullrequest has not been updated in a while and might be stale label Mar 30, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 7, 2023
@eugenejeonme
Copy link

Thanks a lot. :)
I'm also using a custom extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Info: Stale The issue or pullrequest has not been updated in a while and might be stale Type: Feature The issue or pullrequest is a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants