New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@tiptap/extension-collaboration is not compatible with ySyncPlugin renderSnapshot #3583
Comments
@martarf Collaboration.extend({
addProseMirrorPlugins() {
const yXmlFragment = yDoc.get('default', Y.XmlFragment) as Y.XmlFragment;
return [
ySyncPlugin(yXmlFragment, {
permanentUserData,
colors: [
{ light: '#ecd44433', dark: '#ecd444' },
{ light: '#ee635233', dark: '#ee6352' },
{ light: '#6eeb8333', dark: '#6eeb83' },
],
}),
];
},
}).configure({
document: yDoc,
}), I am also trying the same thing, using versions in tiptap, so far I don't get any success. Do you have example for this? Thanks |
Any updates here? |
@iarmankhan Following the example written by dmonad here you can store and show the authors of the content by using
and
But since I got no response here I still had to extend the Collaboration plugin and add the missing permanentUserData option myself as described in the issue. |
@martarf @iarmankhan Did you successful use snapshots with tiptap? I've been trying to integrate the versions demo by dmonad with the above suggestions but can't seem to unrender a snapshot without losing the current editors contents. edit: I've figure this out in the end - turned out I wasn't including the necessary Mark for displaying ychange text. |
What’s the bug you are facing?
I am working on a project built on top of Tiptap and @tiptap/extension-collaboration. (Huge thank you for the libraries, they are amazing).
I am trying to leverage YJS snapshots to build a feature that renders the document history (showing who edited what part of the doc) as described in the prosemirror demo by @dmonad.
However, @tiptap/extension-collaboration does not allow me to configure the options object needed for ySyncPlugin so when it tries to read the permanentUserData prop it throws an error
You can see here that the current extension only includes
vs
So I am unable to leverage renderSnapshot and unrenderSnapshot unless I fork the extension to be able to inject my own permanentUserData.
I'm happy to send a PR but I wanted to understand if there was a reason behind this choice.
Thanks!
Which browser was this experienced in? Are any special extensions installed?
Chrome, Firefox, Safari. Not a browser issue.
How can we reproduce the bug on our side?
fixed by updating https://github.com/ueberdosis/tiptap/tree/main/packages/extension-collaboration to
Can you provide a CodeSandbox?
https://codesandbox.io/s/smoosh-dew-4vt1x8?file=/src/App.js
What did you expect to happen?
I would expect
@tiptap/extension-collaboration
to be fully configurable with all the options allowed byySyncPlugin
iny-prosemirror
Anything to add? (optional)
No response
Did you update your dependencies?
Are you sponsoring us?
The text was updated successfully, but these errors were encountered: