Move y-prosemirror to peer-deps #3763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
bdbch
previously approved these changes
Feb 21, 2023
bdbch
approved these changes
Feb 21, 2023
HengCC
reviewed
Mar 1, 2023
| }, | ||
| "devDependencies": { | ||
| "@tiptap/core": "^2.0.0-beta.218" | ||
| "@tiptap/core": "^2.0.0-beta.218", | ||
| "y-prosemirror": "1.0.20" |
There was a problem hiding this comment.
Why move this to peer&dev dependencies? I think it should be a dependency of the extension itself . Now i have to manually depend on it in the main project after upgrading.
aliasliao
pushed a commit
to aliasliao/tiptap
that referenced
this pull request
May 24, 2023
Co-authored-by: Dominik <6538827+bdbch@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.