Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Horizontal rule by input rule adds extra paragraph node above #3809

Closed
1 of 2 tasks
thefinnomenon opened this issue Mar 2, 2023 · 6 comments · Fixed by #4289
Closed
1 of 2 tasks

Horizontal rule by input rule adds extra paragraph node above #3809

thefinnomenon opened this issue Mar 2, 2023 · 6 comments · Fixed by #4289
Labels
Type: Bug The issue or pullrequest is related to a bug

Comments

@thefinnomenon
Copy link

What’s the bug you are facing?

When adding a horizontal rule using an input rule (--- or ___ ), it adds an empty paragraph node before the divider node.

Which browser was this experienced in? Are any special extensions installed?

Doesn't apply.

How can we reproduce the bug on our side?

You can recreate it in the horizontal rule playground https://tiptap.dev/api/nodes/horizontal-rule
enter ---

Can you provide a CodeSandbox?

No response

What did you expect to happen?

I expect it to only add the divider

Anything to add? (optional)

No response

Did you update your dependencies?

  • Yes, I’ve updated my dependencies to use the latest version of all packages.

Are you sponsoring us?

  • Yes, I’m a sponsor. 💖
@thefinnomenon thefinnomenon added the Type: Bug The issue or pullrequest is related to a bug label Mar 2, 2023
@rfgamaral
Copy link
Contributor

Yes, I use horizontal rules a lot, and this one is very annoying. Hope it gets some attentiont soon, it shouldn't be too hard to fix 😅

@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2023

This issue is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Info: Stale The issue or pullrequest has not been updated in a while and might be stale label Jun 2, 2023
@rfgamaral
Copy link
Contributor

Still valid.

@github-actions github-actions bot removed the Info: Stale The issue or pullrequest has not been updated in a while and might be stale label Jun 3, 2023
@steven-tey
Copy link

@rfgamaral @thefinnomenon here's a patch for this that worked for me: #3859 (comment)

@thefinnomenon
Copy link
Author

Thanks, yeah I have been using that patch and it works perfectly!

@rfgamaral
Copy link
Contributor

Thank you, @steven-tey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug The issue or pullrequest is related to a bug
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants