Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: TextSelection warning of HorizontalRule extension #3997

Closed
1 of 2 tasks
Pareder opened this issue Apr 30, 2023 · 2 comments
Closed
1 of 2 tasks

[Bug]: TextSelection warning of HorizontalRule extension #3997

Pareder opened this issue Apr 30, 2023 · 2 comments
Assignees
Labels
Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Info: Duplicate The issue or pullrequest is a duplicate of another issue or pullrequest Type: Bug The issue or pullrequest is related to a bug

Comments

@Pareder
Copy link

Pareder commented Apr 30, 2023

Which packages did you experience the bug in?

@tiptap/extension-horizontal-rule

What Tiptap version are you using?

2.0.3

What’s the bug you are facing?

Actually it is a copy of this issue #2846, but it was closed and the issue was not fixed, so I decided to recreate this issue. Try to click on button and open console, there will be a TextSelection warning. It is needed to refactor these lines of HorizontalRule extenstion

What browser are you using?

Chrome

Code example

https://codesandbox.io/s/focused-blackburn-7rl1q8?file=/src/App.js

What did you expect to happen?

No warning is displayed.

Anything to add? (optional)

No response

Did you update your dependencies?

  • Yes, I’ve updated my dependencies to use the latest version of all packages.

Are you sponsoring us?

  • Yes, I’m a sponsor. 💖
@Pareder Pareder added Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Triage: Open A new issue or pullrequest that requires triage (added by default) Type: Bug The issue or pullrequest is related to a bug labels Apr 30, 2023
@sjdemartini
Copy link
Contributor

This seems to be a duplicate of #3003, which is still open.

@svenadlung
Copy link
Contributor

Duplicate of #3003

@svenadlung svenadlung marked this as a duplicate of #3003 Aug 4, 2023
@bdbch bdbch added Info: Duplicate The issue or pullrequest is a duplicate of another issue or pullrequest and removed Triage: Open A new issue or pullrequest that requires triage (added by default) labels Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Info: Duplicate The issue or pullrequest is a duplicate of another issue or pullrequest Type: Bug The issue or pullrequest is related to a bug
Projects
None yet
Development

No branches or pull requests

4 participants