Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Cmd+Shift+B should not trigger bold - and same for the other marks #4006

Open
1 of 2 tasks
Nantris opened this issue May 2, 2023 · 5 comments
Open
1 of 2 tasks
Labels
Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Triage: Open A new issue or pullrequest that requires triage (added by default) Type: Bug The issue or pullrequest is related to a bug

Comments

@Nantris
Copy link
Contributor

Nantris commented May 2, 2023

Which packages did you experience the bug in?

bold

What Tiptap version are you using?

2.0.0

What’s the bug you are facing?

The hotkeys for triggering marks should be limited to exactly the keys specified and not trigger in response to additional keys like Shift.

Same for italics, underline, and perhaps more.

What browser are you using?

Chrome on Linux (so specifically using ctrl, not cmd)

Code example

https://tiptap.dev/api/marks/bold

What did you expect to happen?

Cmd+Shift+B or Ctrl+Shift+B should do nothing - but instead they add bold.

Anything to add? (optional)

This also interferes with the blockquote extension's default hotkeys of Cmd+Shift+B: https://tiptap.dev/api/nodes/blockquote

Did you update your dependencies?

  • Yes, I’ve updated my dependencies to use the latest version of all packages.

Are you sponsoring us?

  • Yes, I’m a sponsor. 💖
@Nantris Nantris added Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Triage: Open A new issue or pullrequest that requires triage (added by default) Type: Bug The issue or pullrequest is related to a bug labels May 2, 2023
@ashu12chi
Copy link

I also faced this issue, the workaround I used here is to explicitly make Ctrl+Shift+B no operation.

@apaar97
Copy link
Contributor

apaar97 commented May 3, 2023

+1, faced the same issue

@Nantris
Copy link
Contributor Author

Nantris commented May 9, 2023

It appears to also be the cause behind this issue: #4005 - and I assume others.

@Nantris
Copy link
Contributor Author

Nantris commented May 16, 2023

There seems to be no way to work around this besides to tap into ProseMirror which seems like extreme overkill.

@bdbch or @svenadlung could we get this added to the roadmap for TipTap 2.2.0?

@Nantris
Copy link
Contributor Author

Nantris commented Jun 7, 2023

I've created #4111 to track the related hotkey failures that affect TipTap by default.

@fbolcic pinging you specifically because you're the only person who reacted but is not subscribed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Triage: Open A new issue or pullrequest that requires triage (added by default) Type: Bug The issue or pullrequest is related to a bug
Projects
Status: Triage open
Development

No branches or pull requests

5 participants