Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Mod-Shift-l shortcut not working for TextAlign extension #4015

Open
1 of 2 tasks
chrisdeeming opened this issue May 4, 2023 · 1 comment
Open
1 of 2 tasks
Labels
Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Triage: Open A new issue or pullrequest that requires triage (added by default) Type: Bug The issue or pullrequest is related to a bug

Comments

@chrisdeeming
Copy link

Which packages did you experience the bug in?

extension-text-align

What Tiptap version are you using?

2.0.0

What’s the bug you are facing?

This is reproducible in my dev environment and on the Extension page so I won't create a separate example.

If you highlight some text and center it with Cmd-Shift-E, then try to return it to left with Cmd-Shift-L, the text stays aligned as Center.

In fact, Cmd-Shift-L has no effect whatsoever.

What browser are you using?

Chrome

Code example

No response

What did you expect to happen?

The alignment should return back to left.

Anything to add? (optional)

No response

Did you update your dependencies?

  • Yes, I’ve updated my dependencies to use the latest version of all packages.

Are you sponsoring us?

  • Yes, I’m a sponsor. 💖
@chrisdeeming chrisdeeming added Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Triage: Open A new issue or pullrequest that requires triage (added by default) Type: Bug The issue or pullrequest is related to a bug labels May 4, 2023
@chrisdeeming
Copy link
Author

Seems to be the specific keyboard combination, at least on macOS.

I tried a bunch and found a bunch that just clash with default OS/browser functionality.

I eventually tried Mod-Shift-o and this works.

Mod-Shift-l might be clashing with my Bitwarden password manager, but I'm not sure. It previously wasn't doing anything, but it now seems to be trying to unlock my vault.

So you can close this if you wish, but it would of course be nice if defined keyboard shortcuts, when the editor has focus, took precedence over system/OS shortcuts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Triage: Open A new issue or pullrequest that requires triage (added by default) Type: Bug The issue or pullrequest is related to a bug
Projects
Status: Triage open
Development

No branches or pull requests

3 participants