Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRO]: when only h2 is enabled, markdown for h1 still works (keyboard shortcut doesn't) #4039

Open
2 tasks done
RicoTrevisan opened this issue May 11, 2023 · 0 comments
Open
2 tasks done
Labels
Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Triage: Open A new issue or pullrequest that requires triage (added by default) Type: Bug The issue or pullrequest is related to a bug

Comments

@RicoTrevisan
Copy link
Contributor

Which packages did you experience the bug in?

core, starter-kit (extension-heading)

What Tiptap version are you using?

latest

What’s the bug you are facing?

There seems to be a mismatch of behavior between the keyboard shortcuts and the markdown ones.

If I activate only heading 2, the keyboard shortcut for h1 will be not work, but the markdown shortcut # will actually change the text into an h2. Is this expected behavior?

Further:

  • ## works as expected: is transformed into an h2
  • ### and others works as expected: is not transformed.

Loom explaining issue: https://www.loom.com/share/24ffccbb17584b78960259c8d0c36e18
Codepen example: https://codepen.io/ricotrevisan/pen/YzjqWBJ
Codesandbox copy: https://codesandbox.io/s/pensive-gianmarco-4dwgqd?file=/index.html

What browser are you using?

Chrome

Code example

https://codesandbox.io/s/pensive-gianmarco-4dwgqd?file=/index.html

What did you expect to happen?

Using the markdown shortcut # should not transform line into

.

Anything to add? (optional)

I would be happy to contribute and look at the code myself, but I don't even know where to start (I'm one of those no-coders slowly learning to code...)

Did you update your dependencies?

  • Yes, I’ve updated my dependencies to use the latest version of all packages.

Are you sponsoring us?

  • Yes, I’m a sponsor. 💖
@RicoTrevisan RicoTrevisan added Category: Pro The issue or pull request is related to the pro packages of Tiptap. Triage: Open A new issue or pullrequest that requires triage (added by default) Type: Bug The issue or pullrequest is related to a bug labels May 11, 2023
@RicoTrevisan RicoTrevisan changed the title [PRO]: [PRO]: when only h2 is enabled, markdown for h1 still works (keyboard shortcut doesn't) May 11, 2023
@svenadlung svenadlung added Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. and removed Category: Pro The issue or pull request is related to the pro packages of Tiptap. labels May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Triage: Open A new issue or pullrequest that requires triage (added by default) Type: Bug The issue or pullrequest is related to a bug
Projects
Status: Triage open
Development

No branches or pull requests

3 participants