fix: do not use window.open for links in readonly mode #4073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `contenteditable` is `true`, the browser doesn't allow direct link opens on clicking the `a` element. This is why we need to call `window.open` to open our links. However, when `contenteditable` is `false`, the default browser mechanism for opening links works and there is no need for using `window.open`.
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
bdbch
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe your changes
This PR prevents opening of links using
window.openon clicking them in readonly mode.How did you accomplish your changes
When
contenteditableistrue, the browser doesn't allow direct link opens on clicking theaelement. This is why we need to callwindow.opento open our links.However, when
contenteditableisfalse, the default browser mechanism for opening links works and there is no need for usingwindow.open.Without this change, TipTap would open 2 new tabs on clicking a link.
How have you tested your changes
By enabling readonly mode and clicking on links.
How can we verify your changes
By enabling readonly mode and clicking on links.
Remarks
[add any additional remarks here]
Checklist
Related issues