Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: TipTap's API doesn't seem to support ProseMirror's built-in autojoin command #4214

Open
1 of 2 tasks
Nantris opened this issue Jul 13, 2023 · 2 comments
Open
1 of 2 tasks
Labels
Triage: Open A new issue or pullrequest that requires triage (added by default)

Comments

@Nantris
Copy link
Contributor

Nantris commented Jul 13, 2023

Which packages did you experience the bug in?

core

What Tiptap version are you using?

2.1.6

What’s the bug you are facing?

I've spent a lot of time trying to work around the inability to use autojoin with TipTap. Is there some way it can be used that I'm overlooking? It seems like it should have a similar interface to the chain() and can() command helpers but it's apparently not implemented in TipTap.

What browser are you using?

Chrome

Code example

No response

What did you expect to happen?

All ProseMirror capabilities should be supported by TipTap in my view.

Anything to add? (optional)

No response

Did you update your dependencies?

  • Yes, I’ve updated my dependencies to use the latest version of all packages.

Are you sponsoring us?

  • Yes, I’m a sponsor. 💖
@Nantris Nantris added Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Triage: Open A new issue or pullrequest that requires triage (added by default) Type: Bug The issue or pullrequest is related to a bug labels Jul 13, 2023
@bdbch
Copy link
Contributor

bdbch commented Jul 14, 2023

Was this added in a more recent version? We may have to update all our prosemirror packages anyway at some point and will need to add new commands to Tiptap too.

Right now I'm a bit packed with other things but will look into a Prosemirror update + command sync when I get to it. Feel free to try it on your own and submit a PR if you need it quick? Looking forward for contributions anyway 🙏

@Nantris
Copy link
Contributor Author

Nantris commented Jul 15, 2023

Thanks for your reply @bdbch. It appears to be quite old, but I guess pretty easy to overlook as I overlooked it for several weeks.

I think it should be callable via something like editor.autojoin().chain().fooCommand().run(). - although practical considerations may necessitate some other API style.

@bdbch bdbch removed Type: Bug The issue or pullrequest is related to a bug Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. labels Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Triage: Open A new issue or pullrequest that requires triage (added by default)
Projects
Status: Triage open
Development

No branches or pull requests

3 participants